Skip to content

feat(solidstart): Add sentry onBeforeResponse middleware to enable distributed tracing#13221

Merged
andreiborza merged 2 commits intodevelopfrom
ab/solidstart-distributed-tracing-metatags
Aug 5, 2024
Merged

feat(solidstart): Add sentry onBeforeResponse middleware to enable distributed tracing#13221
andreiborza merged 2 commits intodevelopfrom
ab/solidstart-distributed-tracing-metatags

Conversation

@andreiborza
Copy link
Copy Markdown
Member

@andreiborza andreiborza commented Aug 5, 2024 •
edited
Loading

Works by adding the Sentry middlware to your src/middleware.ts file:

import { sentryBeforeResponseMiddleware } from '@sentry/solidstart/middleware';
import { createMiddleware } from '@solidjs/start/middleware';

export default createMiddleware({
  onBeforeResponse: [
    sentryBeforeResponseMiddleware(),
    // Add your other middleware handlers after `sentryBeforeResponseMiddleware`
  ],
});

And specifying ./src/middleware.ts in app.config.ts

CleanShot 2024-08-05 at 08 51 51@2x

Closes: #12551

@andreiborza andreiborza requested review from Lms24, mydea and s1gr1d August 5, 2024 06:54
s1gr1d
s1gr1d approved these changes Aug 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Lms24
Lms24 approved these changes Aug 5, 2024
View reviewed changes
@andreiborza @Lms24
Update packages/solidstart/README.md
89125a4 
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@andreiborza andreiborza merged commit 4ebac94 into develop Aug 5, 2024
@andreiborza andreiborza deleted the ab/solidstart-distributed-tracing-metatags branch August 5, 2024 07:31
@q1blue q1blue mentioned this pull request Aug 27, 2024
Open
@gokulk16 gokulk16 mentioned this pull request Aug 27, 2024
Closed
@voidedstarlight voidedstarlight mentioned this pull request Aug 27, 2024
Closed
This was referenced Aug 27, 2024
Open
Merged
@sleidig sleidig mentioned this pull request Aug 27, 2024
Closed
@tomwwinter tomwwinter mentioned this pull request Aug 27, 2024
Closed
@aam-digital-ci aam-digital-ci mentioned this pull request Aug 27, 2024
Closed
@chaitanyapotti chaitanyapotti mentioned this pull request Aug 27, 2024
Open
@gokulk16 gokulk16 mentioned this pull request Aug 28, 2024
Closed
This was referenced Aug 28, 2024
Open
Open
@q1blue q1blue mentioned this pull request Aug 28, 2024
Open
This was referenced Aug 29, 2024
Open
Open
@sleidig sleidig mentioned this pull request Aug 29, 2024
Closed
@gokulk16 gokulk16 mentioned this pull request Aug 30, 2024
Merged
This was referenced Aug 30, 2024
Open
Open
@tomwwinter tomwwinter mentioned this pull request Aug 30, 2024
Closed
@tomwwinter tomwwinter mentioned this pull request Aug 30, 2024
Closed
@q1blue q1blue mentioned this pull request Aug 30, 2024
Open
@angeloreale angeloreale mentioned this pull request Aug 31, 2024
Open
@FengShangWuQi FengShangWuQi mentioned this pull request Sep 1, 2024
Closed
@PierreGode PierreGode mentioned this pull request Sep 4, 2024
Open
This was referenced Sep 4, 2024
Closed
Closed
@q1blue q1blue mentioned this pull request Sep 7, 2024
Open
@FengShangWuQi FengShangWuQi mentioned this pull request Sep 8, 2024
Closed
This was referenced Sep 8, 2024
Open
Open
@bagulm123 bagulm123 mentioned this pull request Sep 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@s1gr1d s1gr1d s1gr1d approved these changes

@mydea mydea Awaiting requested review from mydea

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add trace metadata to solidstart template

3 participants

@andreiborza @Lms24 @s1gr1d